Closed original-birdman closed 7 years ago
Hi,
I use busybox code. And busybox defines bb_errno: https://github.com/oe-alliance/ofgwrite/blob/master/busybox/include/libbb.h#L322 I took the code from busybox and have modified it in only few places. This is I think one of the places. I had to comment the part
as I otherwise had problems.
You mean this warning? busybox/libbb/remove_file.c:19:16: warning: comparison between pointer and integer [enabled by default]
Very strange. I thought remove_file.c is original busybox source code, but it seems I have changed that :-(
So it seems your right. I'll check that and will merge pull request when I get no problems compiling the code.
Thanks for PR!
This code is using 'bb_errno', but that is a pointer, so the compiler produces a warning (which is how I noticed it). I suspect it should use errno (as the rest of the ofgwrite code does). But it's possible(?) that it should be *bb_errno, although nothing else uses that - beyond it being declared.
I don't have any example of the code actually being used...