search

oe-lite / core

Official OE-lite/core repository - moved to GitLab.com
https://gitlab.com/oe-lite/core
Other
4 stars 17 forks source link

metadata: delete various stuff that will never be used #219

Closed Villemoes closed 7 years ago

Villemoes commented 7 years ago

These patches reduce our memory consumption somewhat as well as make metadata hashing faster. The biggest one is the first which seems to cut 18% of the memory (obviously depending on use flags, architecture etc.); the others are icing I stumbled on a while ago.

esben commented 7 years ago

While I tend to agree with you that this most likely not cause any real problems, I cannot 100% convince myself that we are not introducing a slight change in metadata semantics. At least any (currently non-existing) pre_cookbook hooks will not be able to alter overrides anymore.

But again, it does look pretty harmless...

Villemoes commented 7 years ago

Well, I suppose one could just do the override trimming after pre_cookbook - without any examples of pre_cookbook hooks, I didn't really know what kind of stuff was supposed to happen there.

esben commented 7 years ago

I guess this whole trimming thing is a good example of something that could happen in a pre_cookbook hook ;)

Villemoes commented 7 years ago

Yes, except for your excellent point about some other hook function modifying OVERRIDES. This really needs to run after stuff in .oe or .oeclass files can no longer affect the metadata. (OK, sneaky guys could probably put arbitrary stuff in some inline-eval-code-with-side-effects and have it run while we compute hashes, but then they get to keep both pieces...)