search

oe1wkl / Morserino-32

Morserino-32 multi-functional Morse code machine, based on ESP32
GNU General Public License v3.0
253 stars 98 forks source link

Koch lesson doesn't get saved #70

Closed dhopfm closed 1 year ago

dhopfm commented 1 year ago

Moserino board revision: 3 Morserino SW version: 4.5.1 Relevant preferences: Koch Sequence: LCWO

Issue description: The current Koch lesson isn't being stored across restarts (HW switch).

Steps to reproduce:

  1. Switch on Morserino
  2. Navigate to Koch Trainer → Select Lesson
  3. Take note of current setting (lesson number/letter), let's call it n
  4. Change lesson number/setting to something else using the rotary encoder, let's call it m
  5. Click rotary encoder to confirm setting and to return to menu
  6. Switch off and on using the hardware switch
  7. Navigate back to Koch Trainer → Select Lesson

Expected result: Morserino remember the changed setting, lesson is set to m.

Actual result: Morserino reverts to the old setting, n.

Please let me know if I can be of any help with debugging! And as always, many thanks for this great project, Willi and team! 73!

oe1wkl commented 1 year ago

I found the bug. Will prepare a maintenance release soon.

Willi

Am 30.03.2023 um 08:59 schrieb David Hopfmueller @.***>:

Moserino board revision: 3 Morserino SW version: 4.5.1

Issue description: The current Koch lesson isn't being stored across restarts (HW switch).

Steps to reproduce:

Switch on Morserino Navigate to Koch Trainer → Select Lesson Take note of current setting (lesson number/letter), let's call it n Change lesson number/setting to something else using the rotary encoder, let's call it m Click rotary encoder to confirm setting and to return to menu Switch off and on using the hardware switch Navigate back to Koch Trainer → Select Lesson Expected result: Morserino remember the changed setting, lesson is set to m.

Actual result: Morserino reverts to the old setting, n.

Please let me know if I can be of any help with debugging! And as always, many thanks for this great project, Willi and team! 73!

— Reply to this email directly, view it on GitHub https://github.com/oe1wkl/Morserino-32/issues/70, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZR72E5GICHAQDHHWPGOU3W6UVOHANCNFSM6AAAAAAWM3FBNI. You are receiving this because you are subscribed to this thread.

dhopfm commented 1 year ago

Fixed in commit 35d7a77/version 4.5.2. Thanks for the quick fix!