oeco / opendev-wptheme

Open Development - JEO child theme
1 stars 6 forks source link

Top bar menu on hover not reacting #12

Open acorbi opened 9 years ago

acorbi commented 9 years ago

bildschirmfoto 2015-02-01 um 10 24 11 Tested using firefox 35.0.1 & chrome 40.0.2214.94 (64-bit) When hovering on the top bar menu over the News or Maps sections, no content is shown. Expected behaviour is that the user can select among the posts of that category.

In case the reason is that there is no post from that category to display, then a message such as "No posts avaialble under this category" should be shown.

Huyeng commented 9 years ago

I agree with Alex, should sow a message if no content available. From my understanding, some news of ODC won't show because ODC's news has post types "news" or "post".

acorbi commented 9 years ago

Then, IMHO, we should do one this 2 things:

  1. Bulk change the post types from "news" or "posts" to that type the theme expects.
  2. Change the theme logic so it presents also posts with types "news" or "posts". @miguelpeixe @Huyeng Which one would you favorise?
miguelpeixe commented 9 years ago

On this theme news and posts are the same post type (post). The news title is just to give more meaning to it. I chose to use the default "post" post type because it already contemplates the concept of news on it's default behaviour, without the need of any extra setup.

Any "news" post type from the previous WordPress theme/setup should be migrated to the "post" post type. If you prefer to use "news" post type I can set it up on this theme.

About the menu, the idea is to not interact with non existing content. The menu that has content gets a different hover style (gray background color) to highlight between the 'static' menus. I can change it to show "no content found", but I think that this way is better.

miguelpeixe commented 9 years ago

Any conclusions on this matter?

acorbi commented 9 years ago

I believe now is working fine.

@Huyeng Are we happy how the menu is working now? Should we close this?