oedotme / generouted

Generated file-based routes for Vite
https://stackblitz.com/github.com/oedotme/generouted/tree/main/explorer
MIT License
1.04k stars 48 forks source link

Generated Routes do not honor vite.config.ts base #129

Closed theixdev closed 3 months ago

theixdev commented 1 year ago

Describe the Bug

Create an app and update it's vite.config.ts to set a base path to something other than '/' i.e '/Test/'

All routes generated ignore the base path.

Generouted Version

@generouted/react-router 1.15.9

Your Example Website or App or Reproduction

None

Steps to Reproduce the Bug or Issue

Create an app and update it's vite.config.ts to set a base path to something other than '/' i.e '/Test/'

All routes generated ignore the base path.

Expected Behavior

As a user I expect the base path config to be respected so that routes will generate with the base path factored in.

i.e if the base path is set to '/Test/' I expect the root index page to navigate to '/Test/' and not '/'

Screenshots or Videos

No response

Platform

Chrome

Additional context

No response

jasonbarry commented 1 year ago

root is not honored either

oedotme commented 1 year ago

Hey @theixdev, as this mostly involve setting a custom basename in the router itself as well, I'd wouldn't expect it to work automatically. You'd need to set the router's basename prop along side Vite's base option.

Here's a comment about enabling base and basename with generouted, mentioned at #102

Hope that helps!

oedotme commented 1 year ago

@jasonbarry In general, there's a customization path if you need to follow a certain directory/project structure specially in non-js projects, here's an example of a custom routes definition + custom plugin options. Workspaces-based monorepos expected to work out-of-the-box though.

Could you provide an example of a setup with a custom root to have more context?

oedotme commented 3 months ago

Closing for inactivity.