Closed madsbuch closed 4 months ago
@madsbuch Thanks for reporting this.
There was a note about that at the v1.19.0 release notes. The Modals
export is no longer available/need as it's included internally.
@oedotme
First, thanks a lot for this library! (I really need to emphasis gratitude for this work, it makes my life much easier!)
Ahh, I see. That makes sense to put it there.
As a note: Me, like many others, reference the library using the ^-operator. We actually had ^1.16.1 in the package.json file. While i know it is good form to have tighter bounds on the versioning, I think most people agree that this is the way to keep up to date with new functions. As such, a breaking change like this would probably have been better to push to a major update, where people have to consider updating the package.
Anywho, I see that the release was cut yesterday, so we will probably see some people wake up to see some failing pipelines today :)
Again, thanks a lot!
A proposal to alleviate that would be to keep the export to const Modal = () => null
and then remove the export from version 2 and forward.
Describe the Bug
I can't immediately see any migration notes for this in the README and the version bumb is also minor, so I would not expect any breaking changes.
Generouted Version
1.19.*
Your Example Website or App or Reproduction
sdcds
Steps to Reproduce the Bug or Issue
Import as in the following:
Expected Behavior
That it imports the component.
Screenshots or Videos
No response
Platform
Additional context
No response