oeed / CraftOS-Standards

Community standard file formats, communication systems, etc. for ComputerCraft and CraftOS 2.0
Other
20 stars 16 forks source link

Rednet Documentation #44

Closed ghost closed 8 years ago

ghost commented 8 years ago

Adds Rednet Standard Documentation as a base for other Communication Standards

oeed commented 8 years ago

Awesome, nice work @justsomeoneelseagain! I haven't really used Rednet much so I'm not really too sure about the content, but it looks like it's pretty complete.

There are a few formatting issues though. As this is the first communication standard we'll need to create a template similar to the file format one, see #45 for that.

ghost commented 8 years ago

@oeed Ok, I´ll trie to add that

ghost commented 8 years ago

@oeed all the data is from the ComputerCraft.jar in assets/lua/rom from the rednet API and the repeater script

ghost commented 8 years ago

dns is in the rednet api too

viluon commented 8 years ago

Thanks for the work @justsomeoneelseagain, I'd say the docs need a little polishing before we can merge this. I've already opened a PR on your fork to fix the typo in the file name ("DNS-Protococ.md"), and I will continue to open PRs as I review the contents.

ghost commented 8 years ago

Thank you @viluon . I tried to get the head table a bit better now.

viluon commented 8 years ago

Thanks for the updates @justsomeoneelseagain! A couple of things:

ghost commented 8 years ago

can someone please reject this pull request, I made anoter branch just for rednet, because in this branch there are things that don´t belong to this pull request, i´ll make a correct pull request after this got re.ected

ghost commented 8 years ago

oh, i can close it

ghost commented 8 years ago

oops

viluon commented 8 years ago

True that, @demhydraz. On the other hand, more than one person should always review a proposal before it can be accepted, and that takes time. There's no need to hurry. As I said, quality is much more important than quantity (or speed, in this case).