oeg-upm / gtfs-bench

GTFS-Madrid-Bench: A Benchmark for Knowledge Graph Construction Engines
https://doi.org/10.5281/zenodo.3574492
Apache License 2.0
17 stars 12 forks source link

Mappings producing different number of results #132

Closed arenas-guerrero-julian closed 3 years ago

arenas-guerrero-julian commented 3 years ago

Describe the bug For GTFS-1-CSV, the current mappings of the generator produce a different number of results (339114) w.r.t. the ones used in https://github.com/oeg-upm/kgc-eval/tree/master/mappings (397622).

dachafra commented 3 years ago

The correct number of results is 395953 not 397622

daniel-dona commented 3 years ago

The correct number of results is 395953 not 397622

I'm getting 455441 using rdfizer :/

Using https://github.com/oeg-upm/kgc-eval/blob/master/mappings/gtfs-csv-noselfjoin.ttl with CSV1 generated with gtfs-bench

daniel-dona commented 3 years ago

At least I'm getting the same number of triples after this fix: https://github.com/oeg-upm/gtfs-bench/commit/d2251950c5aa7f45bd19eb221c90504fd23adb06

Can you confirm @ArenasGuerreroJulian ?

dachafra commented 3 years ago

we have changed the generator, so it would be possible that the number of triples changes, although it shouldn't...

arenas-guerrero-julian commented 3 years ago

I am not getting results, its is killing the memory @daniel-dona . But I am getting different number of POMs with respect to former mappings

daniel-dona commented 3 years ago

I am not getting results, its is killing the memory @daniel-dona . But I am getting different number of POMs with respect to former mappings

That's strange, what tool are you using?

dachafra commented 3 years ago

Bug found in the generated mapping: Shape_points TriplesMap only contains 2 POM (class and lat)

Missing these ones:

      - [geo:long,$(shape_pt_lon),xsd:double]     
      - [gtfs:pointSequence,$(shape_pt_sequence)]      
      - [gtfs:distanceTraveled,$(shape_dist_traveled)]
dachafra commented 3 years ago

Still trying to find what happens in Shapes...

dachafra commented 3 years ago

after some checks, seems shapes are ok! So only that shape_points issue ;-)

dachafra commented 3 years ago

solved!