oeg-upm / mapeathor

Translator of spreadsheet mappings into R2RML, RML or YARRRML
https://morph.oeg.fi.upm.es/tool/mapeathor
Apache License 2.0
30 stars 10 forks source link

Constant, full URI in Object column is generated wrong in RML #44

Closed PapoutsoglouE closed 1 year ago

PapoutsoglouE commented 2 years ago

I have a declared a prefix declared in my spreadsheet, p: http://demo.org/data/ In the Predicate_Object sheet, in the Object column, it works fine if I provide a constant value using this prefix as p:item. The RML is generated correctly and looks like:

    rr:predicateObjectMap [
                rr:predicateMap [ rr:constant some:property];
                rr:objectMap    [ rr:constant p:item; rr:termType rr:IRI; rr:datatype xsd:anyURI ]
    ];

However, if I specify the full URI in the same cell in my spreadsheet, i.e. http://demo.org/data/item instead of p:item, the RML output is incorrect:

    rr:predicateObjectMap [
                rr:predicateMap [ rr:constant some:property];
                rr:objectMap    [ rr:constant http://demo.org/data/item; rr:termType rr:IRI; rr:datatype xsd:anyURI ]
    ];

For the RML/TTL to be valid, the URI in question should be in quotes. I understand that full, constant URI values should be supported Predicate_Objects/Objects, so this looks like a bug.

anaigmo commented 2 years ago

Hi! I see the issue, what datatype did you specify for the full URI?

RichDijk commented 2 years ago

Not sure what you mean by "the full URI"? Maybe this that in the Predicate_object tab we used iri.

ID Predicate Object DataType
IdDemo some:property http://demo.org/data/item iri
anaigmo commented 2 years ago

That's what I wanted to see, thanks :) Indeed it is a bug, will be fixed for the next release

anaigmo commented 1 year ago

Fixed on release v1.6.0