Upgrade to MDHT 3.0 - Githubissues

oehf / ipf

Open eHealth Integration Platform

http://oehf.github.io/ipf-docs

Apache License 2.0

168 stars 64 forks source link

Upgrade to MDHT 3.0 #118

Open unixoid opened 8 years ago

unixoid commented 8 years ago

The development of MDHT is being continued on http://projects.eclipse.org/projects/modeling.mdht. MDHT is even a Maven project now, but its JARs do not seem to be published. Therefore I cloned https://git.eclipse.org/r/mdht/org.eclipse.mdht (branch "mars"), build the JARs by myself, and made some changes to the IPF code -- see commit 9d307e05c2badbd20dcca3606423498f769f8705 in the IPF branch "mdht30".

Problems/doubts:

the unit test org.openehealth.ipf.modules.cda.CDAR2ValidatorTest#validateCCDError fails (set to Ignore for the time being).
org.openehealth.ipf.modules.cda.CDAR2Utils became somehow redundant because MDHT 3.0 contains only one CDAPackage.

Any hints will be highly appreciated. Please feel free to take over this upgrade -- I just have seen a presentation about the MDHT some days ago and wanted to look whether IPF can use this new version...

unixoid commented 7 years ago

BTW, the presentation I mentioned is available under https://wiki.phdsc.org/images/3/39/MDHT_on_FHIR_07-11-2016.pdf. MDHT 3.0 supports FHIR, but I am not sure that we need this...

jkiddo commented 7 years ago

The diff between the test files that are used in the tests of CDAR2ValidatorTest (InvalidCCDDocument.xml and SampleCCDDocument.xml) is found on line 10 (the extension "POCD_HD000040_INVALID")and line 109 (serviceEvent classCode). I would expect the validator to find the extension on line 10 and throw an error on that. It is however not the current case

jkiddo commented 7 years ago

Given that the typeId does not follow the standard, (as mentioned the typeId is bad - http://www.cdapro.com/know/25007) it is a bug that it validates. Now, the correct place to fix it would be in the mdht project, but who is in charge of that project?

unixoid commented 7 years ago

The list of MDHT project members can be found on http://projects.eclipse.org/projects/modeling.mdht/who

jkiddo commented 7 years ago

http://dev.eclipse.org/mhonarc/lists/mdht-dev/msg00146.html

jkiddo commented 7 years ago

Please be aware that using MDHT v3.0 causes a namespace change - eg. ClinicalDocument is in a package named org.eclipse.mdht.uml.cda.ClinicalDocument and NOT org.openhealthtools.mdht.uml.cda.ClinicalDocument

unixoid commented 7 years ago

BTW, there seems to be another MDHT fork from Switzerland: sources, release JARs, snapshot JARS.