oehf / ipf

Open eHealth Integration Platform
http://oehf.github.io/ipf-docs
Apache License 2.0
175 stars 64 forks source link

ITI-18 QueryResponse - QueryResponseTransformer submissionSet to ebXml missing objectType attribute in Classification element #434

Closed cyrillzadra closed 11 months ago

cyrillzadra commented 11 months ago

Hi all,

I am currently investigating a problem where the ITI-18 GetSubmissionSet returns a SubmissionSet containing a classification element without the attribute "objectType."

<Classification classifiedObject="urn:uuid:199493bb-6098-45d8-8bc2-2db313765df4" 
      classificationNode="urn:uuid:a54d6aa5-d40d-43f9-88c5-b4633d873bdd" 
      id="urn:uuid:8710e0f2-4ae0-4ba2-8fb4-87ed922b7844"/>

The mapping of SubmissionSet to ebXml seems to be happening here -> QueryResponseTransformer

Shouldn't a registry in the ITI-18 response have "Classification.objectType" set? Reading through the IHE spec, I found the following definition for "Classification/@objectType":

"Fixed value as specified by ebRIM. Optional upon submission of objects, required upon retrieval. If set, the value shall be urn:oasis:names:tc:ebxml-regrep:ObjectType:RegistryObject:Classification."

https://profiles.ihe.net/ITI/TF/Volume3/ch-4.2.html#4.2.1.2.1 - Table "4.2.1.2.1-1: XML encoding of SubmissionSet Classification"

Thanks & regards, Cyrill

Thopap commented 11 months ago

Hello @cyrillzadra ,

i think you are right. Interesting to see such findings even after years of connectathons :-) (since there is no real need for this attribute at all) I have done a short validation of a FindSubmissionSet with the EVS tool: https://gazelle.ihe.net/evs/report.seam?oid=1.3.6.1.4.1.12559.11.11.4.8416

Even the IHE EVS validator did not indicate that topic. The Rule 43 seems to only validate the objectType of classifications "if present".

I will slightly adjust our response rendering to address this topic.

Best regards, Thomas

cyrillzadra commented 11 months ago

I have done a short validation of a FindSubmissionSet with the EVS tool: https://gazelle.ihe.net/evs/report.seam?oid=1.3.6.1.4.1.12559.11.11.4.8416

Even the IHE EVS validator did not indicate that topic. The Rule 43 seems to only validate the objectType of classifications "if present".

Yeah validated an example against evs tool as well and it confused me even more because it said 'if present' in rule 43:-).

I will slightly adjust our response rendering to address this topic.

Cool thanks. If you don't find time just let me know. I can try to publish this change as pr.

regards Cyrill

cyrillzadra commented 11 months ago

Wow that was fast ... thanks👍

Thopap commented 11 months ago

Slighly extend that issue, since the objectType was misssing for RegistryPackage and ExternalIdentifier as well.