search

oekazuma / svelte-meta-tags

Svelte Meta Tags provides components designed to help you manage SEO for Svelte projects.
MIT License
539 stars 24 forks source link

fix twitter card info #1145

Closed ryoppippi closed 1 month ago

ryoppippi commented 3 months ago

add extra meta tags Documentation: https://developer.x.com/en/docs/x-for-websites/cards/overview/markup

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 716a48bc24e5f276c179a3d19a331ae122d4f6bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | svelte-meta-tags | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

oekazuma commented 3 months ago

Could you add a test? It's okay to create a new file for Twitter for the test.

The test is here. https://github.com/oekazuma/svelte-meta-tags/tree/main/tests

oekazuma commented 2 months ago

Deleting twitter.handle is a breaking change, so I'd like to include it in the major version release. Can I change it so that twitter.handle is retained?

The cause of the CI failure is a discrepancy in the version of playwright, so I think it will be fixed if you merge the latest main.

ryoppippi commented 2 months ago

Okay. Thanks Also this or is still work in progress so I'll convert it as a draft pr