search

oekazuma / svelte-meta-tags

Svelte Meta Tags provides components designed to help you manage SEO for Svelte projects.
MIT License
536 stars 24 forks source link

feat!(twitter): update twitter spec #1200

Closed ryoppippi closed 1 month ago

ryoppippi commented 1 month ago

Hi! I added a twitter update.

I create this PR as a draft. If this is okay, |'ll generate a changeset

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 4af0b4635ce4edb0a19c21512b7d66fd32a34bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | svelte-meta-tags | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

oekazuma commented 1 month ago

Looks good, but the newly added properties aren't there, so I'd like you to add tests.

There are a lot of properties, so add a new twitter/+page.svelte and tests/twitter.test.ts.

ryoppippi commented 1 month ago

@oekazuma done! Plz review it!

ryoppippi commented 1 month ago

I missed some elements in test, so I added

oekazuma commented 1 month ago

@ryoppippi

Thank you!