coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 3696508122
- 8 of 87 (9.2%) changed or added relevant lines in 4 files are covered.
- 3 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-1.3%) to 54.655%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| dhnx/optimization/add_components.py | 0 | 1 | 0.0% | ||
| dhnx/gistools/geometry_operations.py | 0 | 14 | 0.0% | ||
| dhnx/gistools/connect_points.py | 2 | 66 | 3.03% | ||
| <!-- | Total: | 8 | 87 | 9.2% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| dhnx/gistools/geometry_operations.py | 3 | 20.83% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 3656966005: | -1.3% |
| Covered Lines: | 1153 |
| Relevant Lines: | 1972 |
jnettels
This PR is mainly for implementing a new feature: Add a new method 'boundary' for creating the building connection point at the boundary/wall of the building, instead of the centroid. This results in much more realistic grid lengths.
Besides this new feature, this PR deals with a couple of issues that are closely related within the code. Creating separate PRs for the individual issues seemed too much of a hassle. Each subsequent commit works on its own, though.
I have not updated any documentation. But since the only(?) documentation of process_geometry(). seems to be the comment on the function itself, that at least is covered by my PR.