search

oemof / DHNx

District heating system optimisation and simulation models
MIT License
27 stars 12 forks source link

Remove simulation part in next release? #119

Open joroeder opened 1 year ago

joroeder commented 1 year ago

I noticed that some tests of the simulation parted do not properly test.

I am wondering how to proceed with the simulation part at all. There are better open source tools for thermo-hydraulic simulation (e.g. pandapipes). Should we remove the simulation part, as there is no active development here in DHNx anymore? This makes maintenance of the rest much easier, as we do not need to update unused tests and code anymore. Furthermore, it could be helpful if the DHNx repo focuses on the optimisation part for new users and further development, and new users and developers are not confused by the different parts (simulation / optimisation).

What do you think? @jnnr

gitfeldhase commented 1 year ago

I think it is a good idea, I used the simulation part and it was not that easy to create reasonable results (as a new user). A wrapper which could create a pandapipes model based on the optimization model would be a great extension.