search

oemof / DHNx

District heating system optimisation and simulation models
MIT License
27 stars 12 forks source link

Simulation: Calculations rely on defined pipe direction #49

Closed jnnr closed 3 years ago

jnnr commented 3 years ago

It is not clear if flow direction defined by mass flows is used in all (thermal) calculations, not the defined pipe direction. This has to be checked.

The mass flow can go opposite to the defined pipe direction, in particular in the case of looped networks. They are not implemented at the moment, but even with tree networks, this can introduce an error if the user does not define all pipes in the direction of the mass flow.

jnnr commented 3 years ago

It should be rather easy to test this: Define a simple tree with pipe direction reversed (from leaf node towards producer).

jnnr commented 3 years ago

This is a bug. The results depend on the pipe directions defined in the input data.

jnnr commented 3 years ago

This is resolved by #60