Closed jnnr closed 3 years ago
Some of the information given in components and components_attrs is not up-to-date any more. Before the release, we need a review and clean up.
In components.csv
In components_attrs:
[x] unit rendered as dot. Render as hyphen.
[x] node_type necessary? Yes.
[x] rename node_type to component_type and add to requirements
[x] Some variables have different variable names in different places (with and without units):
ThermalNetwork vs NumpySimulationModel length length_m diameter diameter_mm heat_transfer_coeff heat_transfer_coefficient_W/mK roughness roughness_mm
[x] In type, mention that these can be either float/series
mass_flow temp_drop temp-env
Some of the information given in components and components_attrs is not up-to-date any more. Before the release, we need a review and clean up.
In components.csv
In components_attrs:
[x] unit rendered as dot. Render as hyphen.
[x] node_type necessary? Yes.
[x] rename node_type to component_type and add to requirements
[x] Some variables have different variable names in different places (with and without units):
ThermalNetwork vs NumpySimulationModel length length_m diameter diameter_mm heat_transfer_coeff heat_transfer_coefficient_W/mK roughness roughness_mm
[x] In type, mention that these can be either float/series
mass_flow temp_drop temp-env