search

oemof / DHNx

District heating system optimisation and simulation models
MIT License
27 stars 12 forks source link

Fix/osmnx import #64

Closed joroeder closed 3 years ago

joroeder commented 3 years ago

The osmnx_import example is not running.

On thing is that there was a wrong attribute name distance instead dist.

The other issue, I don't know, I commented the lines. The principal import works now, however, likely not properly at the current state. Could you have a look at it @jnnr ?

jnnr commented 3 years ago

I think it would be good to solve this before continuing the actual issue with the division of edges ..

So this does not fix issue #48? Then it should not say so. Can you instead describe the issue you are solving with this PR? Can be in the first comment of this PR, but would be very helpful!

joroeder commented 3 years ago

So this does not fix issue #48?

This PR was indendet to do so, and it is not finshed yet ;-)

However, I see your point. It makes sense to use a separate PR for that. I will update the PR description.

joroeder commented 3 years ago

the distance attribute changed in osmnx v0.13.0:

https://github.com/gboeing/osmnx/blob/master/CHANGELOG.md#0130-2020-05-25

joroeder commented 3 years ago

Some general questions and comments on the osmnx import

Please ignore this comment.

joroeder commented 3 years ago

Okay, I fixed the issues regarding the not-running osmnx-import example, which means an update according to the actual osmnx version (0.16.1). I added this version requirement to the extras_require of setup.py.

The other issues (like #48) of the osmnx import are not solved with this PR.

joroeder commented 3 years ago

@jnnr Since this branch is for review for more than 4 months now ;-) and it contains only small fixes by updating the API of the osmnx package, I would merge this branch if I don't hear anything by the end of next week.