oemof / demandlib

Creating heat and power demand profiles from annual values.
https://oemof.org
MIT License
54 stars 38 forks source link

Release of v0.1.7 #31

Closed uvchik closed 3 years ago

uvchik commented 3 years ago
p-snft commented 3 years ago

You might want to set this default to false, to maintain the previous bahaviour:

https://github.com/oemof/demandlib/blob/cd6a83d6d3d4b10e0e129138cb3d00f5cba5d9af/demandlib/bdew.py#L127

uvchik commented 3 years ago

...or adding a warning?

I principally agree that using the dynamic function should be the default.

p-snft commented 3 years ago

It should, once it does not have performance issues any more.

uvchik commented 3 years ago

So I will add a FutureWarning that in future the default value will be True but for the next release we will set it to False, okay?

p-snft commented 3 years ago

I did this now. (I heard complaints about the officially released version requiring legacy versions of other packages.)

p-snft commented 3 years ago

Done