Fix pandas issues - Githubissues

oemof / demandlib

Creating heat and power demand profiles from annual values.

https://oemof.org

MIT License

54 stars 38 forks source link

Fix pandas issues #34

Closed p-snft closed 3 years ago

p-snft commented 3 years ago

This PR introduces the following changes:

Rework generation of time series to allow usage of Pandas >= 1.2
Require more recent version of dependencies (pandas>=1.0, numpy >= 1.17)
Split electric and thermal profile generation into two files (helped with debugging)
Test sums over individual profiles instead of sum over all profiles (still no unit test, but an improvement, see #35)

pep8speaks commented 3 years ago

Hello @p-snft! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-01-25 15:49:36 UTC

p-snft commented 3 years ago

Setting pandas to < 1.2 might workaround the issue but does not solve it. 1.2 has improved error detection, so our code is probably erroneous:

https://github.com/pandas-dev/pandas/issues/16228

p-snft commented 3 years ago

The decrease in Coverage is actually caused by the dynamic H0 function. As the CI pipeline was broken, however, the decreased coverage was not recognised. In my opinion, the testing should be addressed in another PR.

p-snft commented 3 years ago

A proper solution might be to

set index as an ordinary column
merge
make column from 1 the index.