search

oemof / demandlib

Creating heat and power demand profiles from annual values.
https://oemof.org
MIT License
54 stars 38 forks source link

Changed heat_building.py to include checks for non-residential shlp_type #55

Closed ddceruti closed 3 weeks ago

ddceruti commented 9 months ago

Now the non residential buildings will throw a ValueError to avoid non supported integers in the database located in src/demandlib/bdew/bdew_data. This made the function heat_building.get_sigmoid_parameters return an empty list if self.shlp_type was not 0 for non-commercial buildings. Updated the documentation of the class HeatBuilding to reflect the needed input data too.

ddceruti commented 9 months ago

Added a few more checks to the heat_building.get_sigmoid_parameters function and added .iloc[0] to avoid warnings.

ddceruti commented 8 months ago

Added checks and slightly improved functions in src/demandlib/bdew/heat_building.py documentation and updated AUTHOR and CONTRIB files

p-snft commented 8 months ago

Why did you close this?

ddceruti commented 8 months ago

Why did you close this?

Hi again, sorry, it was not intentional. Thanks for reopening, I checked the code and it is working.

maurerle commented 3 months ago

any update on this? :)

ddceruti commented 3 months ago

Hi, I added the small simplifications as suggested by @p-snft . All clear from my side .

ddceruti commented 2 months ago

Hi @maurerle I added a new commit with your improvements.