search

oemof / feedinlib

This repository contains implementations of photovoltaic models to calculate electricity generation from a pv installation based on given solar radiation. Furthermore it contains all necessary pre-calculations.
MIT License
102 stars 44 forks source link

Add factor to allow scaling, scaling is not possible at the moment #65

Closed uvchik closed 3 years ago

uvchik commented 3 years ago

In the simple_feedin.py example I found the following code:

feedin_scaled = e82.feedin(
    weather=weather_df_wind,
    location=(52, 13),
    scaling="nominal_power",
    scaling_value=5e6,
    )

In my opinion it does not work without the changes of this PR.

birgits commented 3 years ago

The 'scaling_value' parameters in the scaling of PV and wind feed-in in the simple_example.py are old parameters that I discarded but forgot to remove from the example. Scaling should be done as shown in the notebooks. When scaling the feed-in, the feed-in is not returned in absolute values but in W/W or in case of PV also in W/m². I would not change that but just fix the example and add a better explanation in the docstring.

p-snft commented 3 years ago

Closed because the problem is actually in the example.