search

oemof / feedinlib

This repository contains implementations of photovoltaic models to calculate electricity generation from a pv installation based on given solar radiation. Furthermore it contains all necessary pre-calculations.
MIT License
102 stars 44 forks source link

Update setup.py #76

Closed jonas912 closed 1 year ago

jonas912 commented 1 year ago

open_FRED-cli is used but not named in setup.py as a requirement to be installed during installation of feedinlib: https://github.com/oemof/feedinlib/blob/773cde0a2e5662b37d3be12d4d4ef6084907f5e6/src/feedinlib/open_FRED.py#L9

therefore I added open_FRED-cli to install_requires list

p-snft commented 1 year ago

Thanks for your contribution. The reason why open_FRED-cli is added to the requirements should be named in the commit/ merge message, would you please edit your comment above so that this will be done?

jonas912 commented 1 year ago

Hello again, I found a missing comma in the setup.py file (after "open-FRED-cli"): https://github.com/oemof/feedinlib/blob/c89e845ca68a7fbcacd7392f6519f47faea7af02/setup.py#L90

Could you please correct this? Thanks in advance.