search

oemof / oemof-tabular

Load oemof energy systems from tabular data sources.
https://oemof-tabular.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Bug: MultiPeriodConstraint tests fail upgrading solph 0.5.2dev0 to 0.5.2dev1 #155

Closed FelixMau closed 9 months ago

FelixMau commented 10 months ago

Tests fail for MultiPeriodConstraints (figures in LP files change for some values)

Tests fails too when using oemof.solph-0.5.3a1. With exactly the same Errors in same tests.

Apparently tests only work with solph 0.5.2dev0

To find the Bug I have been running tests with different settings (S for Success and F for failure); Version solph 0.5.2 solph 0.5.2dev0 solph 0.5.2dev1 solph 0.5.3a1 solph /feature/integrate_tsam
tabular tsam F S F F F
tabular dev F S F F F

Then I went to check on changes in oemof.solph from 0.5.2dev0 towards 0.5.2dev1 and examined different commits. Breaking commit seems to be an update to docstrings which appears very (very) weird to me.

FelixMau commented 10 months ago

After Updating Pycharm (thanks for tipp @henhuy) and properly tracking branches. Found out that (of course) not the change in Docstrings is breaking but accounting for ramainging values of multi period investments.

Since also within solph the LP files have been updated we should check our LP files as well and upgrade them eventually. At first sight the pattern of changes applied to solph LP files fits differences observed in tabular LP file changes.

FelixMau commented 9 months ago

Upgrade to oemof.solph 0.5.2dev2 includes update of LP files leading to succesfully running tests!