Open SabineHaas opened 3 months ago
I think the names are ok, I could only think of ConversionGHG and CommodityGHG to make the class name shorter
I like your proposition as I find ConversionWithEmissions and ConversionWithEmissions quite long and unhandy.
In the sedos project we need to model emissions as flows as we are using CCS in our energy system. Currently there's now facade in oemof.tabular handling this.
After issue #176 and discussions with @henhuy I would implement the following either in a new PR or using #170
ConversionWithEmissions
andCommodityWithEmissions
which might be children ofConversion
andCommodity
marginal_costs
will stay associated with the flows they are associated with now.emission_bus_0
,emission_bus_1
etc.emission_factors
are added and processed like inmimo.csv
and MIMO facadeconversion_factors
of a converter in oemof.solphWould be happy to hear your feedback also about the naming @Bachibouzouk & @henhuy