oemof / oemof-tabular

Load oemof energy systems from tabular data sources.
https://oemof-tabular.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Make tabular work with solph v0.5.0 #57

Closed jnnr closed 1 year ago

jnnr commented 2 years ago

Adapts tabular to work with the current dev branch of oemof.solph, which will be released as v0.5 soon. TODO

Depending on changes in solph v.5.1:

Check if needs to be handled:

Post-processing is not working and will be removed/replaced in #102:

jnnr commented 1 year ago

Important todo: Check that the changes in 33c641c are as expected.

henhuy commented 1 year ago

I just tried to install oemof.solph v0.5.1 (there are two tags v0.5.1.dev0 and v0.5.1.dev1) as dependency, to check whether link test is working:

I think this PR should use oemof.solph v0.5.1 as dependency for now (as git dependency) and we should adapt version once oemof.solph v0.5.1 has been released. I don't know what version will be released (dev0 or dev1), but we should make sure that tabular works with the chosen one.

Regarding the postprocessing tests - I will try to merge new postprocessing, so that we can rebase this branch onto dev and fix/adapt postprocessing tests for solph 0.5

nailend commented 1 year ago

I just tried to install oemof.solph v0.5.1 (there are two tags v0.5.1.dev0 and v0.5.1.dev1) as dependency, to check whether link test is working:

  • In version v0.5.1.dev0, link test is still not working due to differences in LP file
  • In version v0.5.1.dev1 all tests are failing due to slightly different results (what's happening there?)

I think this PR should use oemof.solph v0.5.1 as dependency for now (as git dependency) and we should adapt version once oemof.solph v0.5.1 has been released. I don't know what version will be released (dev0 or dev1), but we should make sure that tabular works with the chosen one.

The test fail due to the mult-period investment which is new in v.0.5.1. This changes the variable names in the LP files. This is easy to fix. Maybe I didn't describe this enough. The link doesn't just work with v5.0.1, the variables still needs to be adjusted. I already tried this locally, the tests will succeed then. I didn't want to blow up this PR, with also adding the multi-period. ITherefore, I suggest not addressing this here but in the PR#105. This PR is already full of a lot of changes in the LP files because of the pyomo update.

henhuy commented 1 year ago

Ah I see! Forgot about the Multi-period feature. It's quite strange, why this big feature will only resolve in a patch and not a minor version. IMO fixing link component would be a patch and MP feature a minor update. Whatever... So, you are right - we should address MP feature in a separate PR