Closed jnnr closed 1 year ago
I just tried to install oemof.solph v0.5.1 (there are two tags v0.5.1.dev0
and v0.5.1.dev1
) as dependency, to check whether link test is working:
v0.5.1.dev0
, link test is still not working due to differences in LP filev0.5.1.dev1
all tests are failing due to slightly different results (what's happening there?)I think this PR should use oemof.solph v0.5.1 as dependency for now (as git dependency) and we should adapt version once oemof.solph v0.5.1 has been released. I don't know what version will be released (dev0 or dev1), but we should make sure that tabular works with the chosen one.
Regarding the postprocessing tests - I will try to merge new postprocessing, so that we can rebase this branch onto dev and fix/adapt postprocessing tests for solph 0.5
I just tried to install oemof.solph v0.5.1 (there are two tags
v0.5.1.dev0
andv0.5.1.dev1
) as dependency, to check whether link test is working:
- In version
v0.5.1.dev0
, link test is still not working due to differences in LP file- In version
v0.5.1.dev1
all tests are failing due to slightly different results (what's happening there?)I think this PR should use oemof.solph v0.5.1 as dependency for now (as git dependency) and we should adapt version once oemof.solph v0.5.1 has been released. I don't know what version will be released (dev0 or dev1), but we should make sure that tabular works with the chosen one.
The test fail due to the mult-period investment which is new in v.0.5.1. This changes the variable names in the LP files. This is easy to fix. Maybe I didn't describe this enough. The link doesn't just work with v5.0.1, the variables still needs to be adjusted. I already tried this locally, the tests will succeed then. I didn't want to blow up this PR, with also adding the multi-period. ITherefore, I suggest not addressing this here but in the PR#105. This PR is already full of a lot of changes in the LP files because of the pyomo update.
Ah I see! Forgot about the Multi-period feature. It's quite strange, why this big feature will only resolve in a patch and not a minor version. IMO fixing link component would be a patch and MP feature a minor update. Whatever... So, you are right - we should address MP feature in a separate PR
Adapts tabular to work with the current dev branch of oemof.solph, which will be released as v0.5 soon. TODO
TypeError: __init__() got an unexpected keyword argument ...
. Need to make sure that super().init only receives arguments that it expects. Could be solved together with #44 or separately if that is cleaner.kwargs_to_parent
. What to do? ab4e979ONE_VAR_CONSTANT
)test_emission_constraint
Depending on changes in
solph v.5.1
:Check if needs to be handled:
nominal_value
, therefore this does not affect the named parameters.Post-processing is not working and will be removed/replaced in #102:
heat-bus
. Pandas .locnot found
problem. Comment this?set_result_index
. Probably because of thenan
entry for the last timestep?Length mismatch: Expected axis has 120 elements, new values have 5 elements