checking fluid vector for fluids not within the network's fluid list

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.

https://tespy.readthedocs.io

MIT License

272 stars 85 forks source link

checking fluid vector for fluids not within the network's fluid list #233

Closed MarBrandt closed 3 years ago

MarBrandt commented 3 years ago

checking fluid vector for fluids not within the network's fluid list
added 'def test_bad_fluids_in_fluid_vector' in 'test_errors.py'
resolve #232

pep8speaks commented 3 years ago

Hello @MarBrandt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-11-04 20:04:18 UTC

fwitte commented 3 years ago

Hi, thanks for the PR! We need to make two adjustments:

one test is failing with the wrong error triggered due to the new feature. This means, the error message, that originally should have been triggered might be obsolete or we need to adjust the test.
add short description in what's new.

Best regards