#Line 253 combustion chamber stoich - issue of dict size change during for loop

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.

https://tespy.readthedocs.io

MIT License

272 stars 85 forks source link

#Line 253 combustion chamber stoich - issue of dict size change during for loop #244

Closed govind-menon110 closed 3 years ago

govind-menon110 commented 3 years ago

General

Describe your pull request as transparent as possible:

What functionality does it implement? Bug Fix
Where is it located? Location: Combustion Chamber Stoich
Which bugs are fixed Received an error: "RuntimeError: dictionary keys changed during iteration" for CombustionChamberStoich on the line "for f in self.air.val.keys():" which can be mitigated by adding a list casting similar to one on line 260 for the fuel
Are there related issues? No

fwitte commented 3 years ago

Hi @govind-menon110, thanks a lot for the fix! I updated the dev branch already! Best regards Francesco

fwitte commented 3 years ago

Hi @govind-menon110, I'll abuse this thread: I answered your e-mail from earlier today, but received an error of the Mail Delivery Systems. It seems, your server rejects the e-mail. I'll just answer here... ;)

Hi Govind,

thanks for reaching out. TESPy is licensed under the MIT license (https://github.com/oemof/tespy/blob/dev/LICENSE), therefore you can use it for your project. The MIT license is quite generous, citing the software https://github.com/oemof/tespy#citation is very much appreciated but not necessarily required. Good luck with your thesis, I wish you all the best :). Let me know once it is finished and published. I am curious of your findings, especially in which way TESPy is implemented in your research.

Best regards

Francesco

govind-menon110 commented 3 years ago

Hi @govind-menon110, I'll abuse this thread: I answered your e-mail from earlier today, but received an error of the Mail Delivery Systems. It seems, your server rejects the e-mail. I'll just answer here... ;)

Hi Govind, thanks for reaching out. TESPy is licensed under the MIT license (https://github.com/oemof/tespy/blob/dev/LICENSE), therefore you can use it for your project. The MIT license is quite generous, citing the software https://github.com/oemof/tespy#citation is very much appreciated but not necessarily required. Good luck with your thesis, I wish you all the best :). Let me know once it is finished and published. I am curious of your findings, especially in which way TESPy is implemented in your research. Best regards Francesco

Thank you very much for the prompt response, @fwitte . I will definitely keep you posted :)