New Component: DiabaticCompressor

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.

https://tespy.readthedocs.io

MIT License

256 stars 80 forks source link

New Component: DiabaticCompressor #300

Closed maltefritz closed 7 months ago

maltefritz commented 2 years ago

See issue #299

pep8speaks commented 2 years ago

Hello @maltefritz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tespy/components/turbomachinery/diabatic_compressor.py:

Line 41:80: E501 line too long (94 > 79 characters) Line 42:80: E501 line too long (81 > 79 characters) Line 43:80: E501 line too long (86 > 79 characters) Line 44:80: E501 line too long (90 > 79 characters) Line 45:80: E501 line too long (87 > 79 characters) Line 235:80: E501 line too long (83 > 79 characters)

lgtm-com[bot] commented 2 years ago

This pull request introduces 5 alerts when merging 68c3612c8f930c73b884214cbf810f59151d7d7e into 518fd8e2156f75022cad227909fdaa58deacf59e - view on LGTM.com

new alerts:

5 for Unused import

fwitte commented 7 months ago

Is this still ongoing?

fwitte commented 7 months ago

One could implement polytropic compressor model here, for example see doi.org/10.1115/1.3239827 or https://www.turbomachinerymag.com/view/compressor-performance-and-thermodynamic.