New Component: DiabaticCombustionChamber

[fwitte]

General

• The DiabaticCombustionChamber features heat loss to the ambient and pressure losses inside the combustion chamber
• Will introduce some changes in the module structure of the component as well to make things more clear for devs (will get own PR)
• Adjusted naming convention: To match this logic,
  • HeatExchangerSimple -> SimpleHeatExchanger
  • CombustionChamber -> AdiabaticCombustionChamber
  • CombustionChamberStoich -> StoichiometricCombustionChamber

Testing

• Tests will be included

ToDo

• [ ] Verify implementation with literature
• [ ] Update code documentation of the component
• [ ] Update online documentation
• [ ] Add example in examples repo
• [ ] Update What's New

Questions and Comments

@KarimHShawky: You can check out this branch and fiddle with the new component in the CGAM example. Let me know, if you need any assistance.

[pep8speaks]

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file src/tespy/components/combustion/base.py:

Line 35:80: E501 line too long (82 > 79 characters) Line 36:80: E501 line too long (92 > 79 characters) Line 37:80: E501 line too long (81 > 79 characters) Line 38:80: E501 line too long (87 > 79 characters)

• In the file src/tespy/components/combustion/diabatic.py:

Line 28:80: E501 line too long (82 > 79 characters) Line 29:80: E501 line too long (92 > 79 characters) Line 30:80: E501 line too long (81 > 79 characters) Line 36:80: E501 line too long (99 > 79 characters) Line 37:80: E501 line too long (87 > 79 characters) Line 94:80: E501 line too long (80 > 79 characters) Line 357:80: E501 line too long (80 > 79 characters)

• In the file src/tespy/components/combustion/engine.py:

Line 43:80: E501 line too long (83 > 79 characters) Line 44:80: E501 line too long (92 > 79 characters) Line 45:80: E501 line too long (81 > 79 characters) Line 46:80: E501 line too long (88 > 79 characters) Line 47:80: E501 line too long (82 > 79 characters) Line 48:80: E501 line too long (81 > 79 characters) Line 49:80: E501 line too long (81 > 79 characters) Line 50:80: E501 line too long (84 > 79 characters) Line 167:80: E501 line too long (84 > 79 characters)

• In the file src/tespy/components/combustion/stoichiometric.py:

Line 37:80: E501 line too long (82 > 79 characters) Line 38:80: E501 line too long (92 > 79 characters) Line 39:80: E501 line too long (97 > 79 characters) Line 40:80: E501 line too long (103 > 79 characters) Line 44:80: E501 line too long (95 > 79 characters) Line 45:80: E501 line too long (91 > 79 characters)

• In the file src/tespy/components/heat_exchangers/base.py:

Line 38:80: E501 line too long (88 > 79 characters) Line 42:80: E501 line too long (92 > 79 characters) Line 44:80: E501 line too long (81 > 79 characters)

• In the file src/tespy/components/heat_exchangers/condenser.py:

Line 40:80: E501 line too long (88 > 79 characters) Line 47:80: E501 line too long (92 > 79 characters)

• In the file src/tespy/components/heat_exchangers/desuperheater.py:

Line 28:80: E501 line too long (88 > 79 characters) Line 33:80: E501 line too long (92 > 79 characters) Line 35:80: E501 line too long (81 > 79 characters)

• In the file src/tespy/components/heat_exchangers/parabolic_trough.py:

Line 37:80: E501 line too long (96 > 79 characters) Line 38:80: E501 line too long (93 > 79 characters)

• In the file src/tespy/components/heat_exchangers/simple.py:

Line 51:80: E501 line too long (96 > 79 characters) Line 52:80: E501 line too long (93 > 79 characters) Line 53:80: E501 line too long (90 > 79 characters) Line 54:80: E501 line too long (95 > 79 characters) Line 306:80: E501 line too long (95 > 79 characters) Line 307:80: E501 line too long (104 > 79 characters)

• In the file src/tespy/components/heat_exchangers/solar_collector.py:

Line 37:80: E501 line too long (96 > 79 characters) Line 38:80: E501 line too long (93 > 79 characters)

• In the file src/tespy/components/piping/pipe.py:

Line 29:80: E501 line too long (96 > 79 characters) Line 30:80: E501 line too long (93 > 79 characters) Line 31:80: E501 line too long (90 > 79 characters) Line 32:80: E501 line too long (95 > 79 characters)

• In the file src/tespy/components/turbomachinery/compressor.py:

Line 41:80: E501 line too long (86 > 79 characters)

• In the file src/tespy/components/turbomachinery/pump.py:

Line 37:80: E501 line too long (86 > 79 characters)

• In the file src/tespy/components/turbomachinery/turbine.py:

Line 38:80: E501 line too long (86 > 79 characters)

Comment last updated at 2022-03-06 10:28:05 UTC

[lgtm-com[bot]]

This pull request introduces 6 alerts when merging 2813bba9f4c608cf4ed6d1a47f37f4c24ab41858 into 51ff17f20c72e848619f9931c1e29f4d890ca9cc - view on LGTM.com

new alerts:

• 6 for Unused import

[lgtm-com[bot]]

This pull request introduces 7 alerts when merging 92977813a8ec2e92bc338fe8cd660b00e91a8393 into 51ff17f20c72e848619f9931c1e29f4d890ca9cc - view on LGTM.com

new alerts:

• 7 for Unused import

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging d908842856321189308c83c34999edce53ce396a into 51ff17f20c72e848619f9931c1e29f4d890ca9cc - view on LGTM.com

new alerts:

• 2 for Unused import