correct assignment of products and educts in component electrolysis

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.

https://tespy.readthedocs.io

MIT License

256 stars 80 forks source link

correct assignment of products and educts in component electrolysis #309

Closed tub-hofmann closed 2 years ago

tub-hofmann commented 2 years ago

https://github.com/oemof/tespy/blob/51ff17f20c72e848619f9931c1e29f4d890ca9cc/src/tespy/components/reactors/water_electrolyzer.py#L313

O2 and H2 are both products and should have the same sign, or not?

However, the error is not critical, since the enthalpy of formation for oxygen and hydrogen is 0.

fwitte commented 2 years ago

Thank you for reporting @tub-hofmann, will be fixed asap.

fwitte commented 2 years ago

Closed by #333