search

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.
https://tespy.readthedocs.io
MIT License
256 stars 80 forks source link

incorrect unit conversion for mass flow rate #316

Closed nkawerau closed 2 years ago

nkawerau commented 2 years ago

I think the unit conversion in global_vars.py for mass flow is wrong.

` 'm': {

    'text': 'mass flow',
    'SI_unit': 'kg / s',
    'units': {'kg / s': 1, 'kg / min': 60, 'kg / h': 3600, 't / h': 3.6},`

` 'v': {

    'text': 'volumetric flow',
    'SI_unit': 'm3 / s',
    'units': {
        'm3 / s': 1, 'm3 / min': 1 / 60, 'm3 / h': 1 / 3.6e3,`

analog to 'v' the units for 'm' should be: 'units': {'kg / s': 1, 'kg / min': 1/60, 'kg / h': 1/3600, 't / h': 1/3.6},

fwitte commented 2 years ago

Well, that went under radar for a veeeery long time. Thanks for reporting!