Add fuel cell draft code

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.

https://tespy.readthedocs.io

MIT License

256 stars 80 forks source link

Add fuel cell draft code #329

Closed matbock closed 1 year ago

matbock commented 2 years ago

The code implements a fuel cell as new component. It is designed just like the water electrolyzer, i.e. it produces water out of hydrogen and oxygen with an additional cooling fluid. The import of the code is implemented in the components init file, the code itself is located in the folder components/reactors.

pep8speaks commented 2 years ago

Hello @matbock! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tespy/components/reactors/fuel_cell.py:

Line 22:80: E501 line too long (83 > 79 characters) Line 23:80: E501 line too long (81 > 79 characters) Line 34:80: E501 line too long (82 > 79 characters)

Comment last updated at 2022-08-14 09:10:28 UTC

lgtm-com[bot] commented 2 years ago

This pull request introduces 5 alerts when merging 1600d090419185f253581ad616cc436ac189aa70 into 26865e3d530b972c59fe0af47d6561843bcdd4d6 - view on LGTM.com

new alerts:

4 for Unused import
1 for First parameter of a method is not named 'self'

fwitte commented 2 years ago

@matbock: I added some ToDos as comments in the code, could you have a look at them? Thanks!