search

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.
https://tespy.readthedocs.io
MIT License
256 stars 80 forks source link

add electrolyzer example #336

Closed BenPortner closed 5 months ago

BenPortner commented 2 years ago

took the example from the doc-string and added it as a stand-alone example to the "example/tutorials" section of the documentation

fwitte commented 2 years ago

Hi,

thank you for your suggestion and please excuse for coming back so late to it. Generally, the docstring examples are accessible in the API documentation. However, they might be kind of hidden (https://tespy.readthedocs.io/en/main/api/tespy.components.html#tespy.components.reactors.water_electrolyzer.WaterElectrolyzer). I think it would be better, if there is a single place for each example.

Maybe we can add a more exhaustive example in the examples list. Maybe something with a storage integration or similar. I will put it up on the oemof meeting agenda for next week. Maybe a small break out group is willing to develop an example :). It would be helpful in any way, I think! If you have an example implementation ready yourself, you are welcome to share it.

Thanks again, I will come back to the PR after next week's user meeting.

fwitte commented 5 months ago

Hi @BenPortner,

I'll close this for the moment, since I restructured many things in the software. Still like the idea to have an example for the hydrogen feature on the top level of the docs, but I would like it to be a slightly larger one... Thank you still!

Best

Francesco