search

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.
https://tespy.readthedocs.io
MIT License
256 stars 80 forks source link

The correct placement of the cycler closer -- Add 'note' in doumentation #403

Open maltefritz opened 1 year ago

maltefritz commented 1 year ago

In a process with splitter and merge, I noticed that the location of the cycler closer is not trivial. The process works only if the component is placed in the part where the total mass flow is present.

So that others are not confronted with the same problem, I suggest to put the following note in dokumentation in 'tespy.components.basics.cycle_closer module':

If a cycle process is separated by a splitter or similar and reconnected by a merge or similar, this component has to be placed in the part of the prozess where the total mass flow is present.

If I find time, I will create a pull request to add this to the documentation.

Best regards

fwitte commented 1 year ago

Hi @maltefritz,

thanks for reporting, do you have a minimal working example for that? I guess something like

a -> b
b -> c
b -> d
c -> cc (cycle closer)
cc -> e
d -> e
e -> a

does not work then, while placing the cycle closer between e and a or a and b would work?

maltefritz commented 1 year ago

Hi @fwitte,

your working example is right. The cycle closer only works between a and e or a and b. I think this component has to be placed in the part of the process where the total mass flow is present.