search

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermodynamic modeling of thermal engineering plants such as power plants, heat pumps or refrigeration machines.
https://tespy.readthedocs.io
MIT License
281 stars 86 forks source link

Remove old newton function and use newton_with_kwargs instead #484

Closed fwitte closed 10 months ago

fwitte commented 10 months ago

The convergence critereon for the newon helper algorithms needed to be updated to target values equal to zero. In case the target value is zero, the tolerance mode is set to absolute difference now. On top of that the old newton function was removed and now all parts of the code use the newton_with_kwargs function.

pep8speaks commented 10 months ago

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 474:80: E501 line too long (90 > 79 characters) Line 505:80: E501 line too long (90 > 79 characters)

Line 41:80: E501 line too long (82 > 79 characters) Line 46:80: E501 line too long (84 > 79 characters) Line 51:80: E501 line too long (82 > 79 characters) Line 57:80: E501 line too long (85 > 79 characters)

Comment last updated at 2024-01-29 18:55:22 UTC