pep8speaks
commented
2 months ago Hello @fwitte! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
src/tespy/components/__init__.py:
- In the file
src/tespy/components/component.py:
Line 221:80: E501 line too long (99 > 79 characters) Line 221:90: E251 unexpected spaces around keyword / parameter equals Line 221:92: E251 unexpected spaces around keyword / parameter equals
- In the file
src/tespy/components/nodes/base.py:
Line 174:25: E261 at least two spaces before inline comment Line 175:23: W291 trailing whitespace Line 206:25: E261 at least two spaces before inline comment
- In the file
src/tespy/connections/connection.py:
Line 504:36: W291 trailing whitespace Line 505:46: E231 missing whitespace after ':' Line 614:38: E231 missing whitespace after ',' Line 614:61: E231 missing whitespace after ',' Line 631:80: E501 line too long (115 > 79 characters) Line 634:80: E501 line too long (85 > 79 characters) Line 676:80: E501 line too long (123 > 79 characters) Line 680:80: E501 line too long (81 > 79 characters) Line 681:80: E501 line too long (114 > 79 characters) Line 685:80: E501 line too long (105 > 79 characters) Line 690:80: E501 line too long (89 > 79 characters) Line 691:80: E501 line too long (105 > 79 characters) Line 764:80: E501 line too long (125 > 79 characters) Line 772:80: E501 line too long (136 > 79 characters) Line 776:80: E501 line too long (136 > 79 characters) Line 780:80: E501 line too long (116 > 79 characters) Line 816:80: E501 line too long (129 > 79 characters) Line 860:80: E501 line too long (110 > 79 characters) Line 866:80: E501 line too long (116 > 79 characters) Line 870:80: E501 line too long (121 > 79 characters) Line 911:80: E501 line too long (136 > 79 characters) Line 928:34: E713 test for membership should be 'not in' Line 928:80: E501 line too long (195 > 79 characters) Line 929:80: E501 line too long (126 > 79 characters) Line 999:71: E231 missing whitespace after ',' Line 999:80: E501 line too long (99 > 79 characters) Line 1017:80: E501 line too long (105 > 79 characters) Line 1050:17: E225 missing whitespace around operator Line 1051:17: E225 missing whitespace around operator Line 1063:80: E501 line too long (109 > 79 characters) Line 1064:80: E501 line too long (109 > 79 characters)
- In the file
src/tespy/networks/network.py:
Line 756:14: E231 missing whitespace after ',' Line 758:21: E231 missing whitespace after ',' Line 758:50: E231 missing whitespace after ',' Line 759:17: E265 block comment should start with '# ' Line 759:80: E501 line too long (83 > 79 characters) Line 776:80: E501 line too long (86 > 79 characters) Line 786:14: E231 missing whitespace after ',' Line 788:21: E231 missing whitespace after ',' Line 788:50: E231 missing whitespace after ',' Line 789:17: E265 block comment should start with '# ' Line 789:80: E501 line too long (83 > 79 characters) Line 811:46: E231 missing whitespace after ',' Line 972:65: W291 trailing whitespace Line 1128:80: E501 line too long (81 > 79 characters) Line 1130:80: E501 line too long (80 > 79 characters) Line 1290:41: E231 missing whitespace after ',' Line 1293:80: E501 line too long (97 > 79 characters) Line 1294:80: E501 line too long (126 > 79 characters) Line 1743:21: E265 block comment should start with '# ' Line 1744:21: E265 block comment should start with '# ' Line 1745:26: E231 missing whitespace after ',' Line 1861:80: E501 line too long (124 > 79 characters) Line 1868:80: E501 line too long (135 > 79 characters) Line 1873:5: E303 too many blank lines (2) Line 2115:80: E501 line too long (80 > 79 characters) Line 2253:26: E221 multiple spaces before operator Line 2253:80: E501 line too long (108 > 79 characters) Line 2253:86: E261 at least two spaces before inline comment Line 2254:26: E221 multiple spaces before operator Line 2254:59: E261 at least two spaces before inline comment Line 2255:26: E221 multiple spaces before operator Line 2255:59: E261 at least two spaces before inline comment Line 2255:80: E501 line too long (80 > 79 characters) Line 2256:23: E221 multiple spaces before operator Line 2256:80: E501 line too long (109 > 79 characters) Line 2256:87: E261 at least two spaces before inline comment Line 2263:22: E221 multiple spaces before operator Line 2265:53: E231 missing whitespace after ',' Line 2265:80: E501 line too long (138 > 79 characters) Line 2339:31: E231 missing whitespace after ',' Line 2339:38: E231 missing whitespace after ',' Line 2339:45: E231 missing whitespace after ',' Line 2339:49: E231 missing whitespace after ',' Line 2346:80: E501 line too long (85 > 79 characters) Line 2355:80: E501 line too long (85 > 79 characters) Line 2373:9: E265 block comment should start with '# ' Line 2380:80: E501 line too long (138 > 79 characters) Line 2380:92: E231 missing whitespace after ',' Line 2380:111: E231 missing whitespace after ',' Line 2380:128: E231 missing whitespace after ',' Line 2381:17: E265 block comment should start with '# ' Line 2385:80: E501 line too long (138 > 79 characters) Line 2385:92: E231 missing whitespace after ',' Line 2385:111: E231 missing whitespace after ',' Line 2385:128: E231 missing whitespace after ',' Line 2386:17: E265 block comment should start with '# ' Line 2393:80: E501 line too long (126 > 79 characters) Line 2394:17: E265 block comment should start with '# ' Line 2400:80: E501 line too long (103 > 79 characters) Line 2400:87: E231 missing whitespace after ',' Line 2400:89: E231 missing whitespace after ',' Line 2400:93: E231 missing whitespace after ',' Line 2402:17: E265 block comment should start with '# ' Line 2413:80: E501 line too long (126 > 79 characters) Line 2413:92: E231 missing whitespace after ',' Line 2413:112: E231 missing whitespace after ',' Line 2413:116: E231 missing whitespace after ',' Line 2415:17: E265 block comment should start with '# ' Line 2415:80: E501 line too long (83 > 79 characters) Line 2418:17: E265 block comment should start with '# ' Line 2418:17: E303 too many blank lines (2) Line 2423:17: E303 too many blank lines (4) Line 2498:14: E261 at least two spaces before inline comment Line 2498:15: E262 inline comment should start with '# ' Line 2636:42: E231 missing whitespace after ',' Line 2637:80: E501 line too long (93 > 79 characters) Line 2638:73: E261 at least two spaces before inline comment Line 2638:80: E501 line too long (120 > 79 characters) Line 2639:80: E501 line too long (127 > 79 characters)
- In the file
src/tespy/networks/network_reader.py:
Line 87:18: E203 whitespace before ':' Line 87:19: E231 missing whitespace after ':' Line 88:33: E203 whitespace before ':' Line 89:39: E203 whitespace before ':' Line 90:45: E203 whitespace before ':' Line 90:80: E501 line too long (86 > 79 characters) Line 91:39: E203 whitespace before ':' Line 92:42: E203 whitespace before ':' Line 92:80: E501 line too long (80 > 79 characters) Line 93:32: E203 whitespace before ':' Line 94:37: E203 whitespace before ':' Line 95:64: E203 whitespace before ':' Line 95:80: E501 line too long (124 > 79 characters) Line 351:80: E501 line too long (85 > 79 characters) Line 354:80: E501 line too long (84 > 79 characters)
- In the file
src/tespy/tools/data_containers.py:
Line 328:80: E501 line too long (82 > 79 characters) Line 595:1: E302 expected 2 blank lines, found 1
- In the file
src/tespy/tools/fluid_properties/functions.py:
Line 96:80: E501 line too long (85 > 79 characters) Line 97:73: E251 unexpected spaces around keyword / parameter equals Line 97:75: E251 unexpected spaces around keyword / parameter equals Line 98:73: E251 unexpected spaces around keyword / parameter equals Line 98:75: E251 unexpected spaces around keyword / parameter equals Line 99:21: E225 missing whitespace around operator Line 99:30: E225 missing whitespace around operator Line 104:62: E203 whitespace before ':' Line 106:53: W291 trailing whitespace Line 111:80: E501 line too long (99 > 79 characters) Line 112:80: E501 line too long (102 > 79 characters) Line 118:80: E501 line too long (99 > 79 characters) Line 119:80: E501 line too long (102 > 79 characters) Line 123:80: E501 line too long (91 > 79 characters) Line 126:80: E501 line too long (95 > 79 characters) Line 128:80: E501 line too long (98 > 79 characters) Line 133:61: E251 unexpected spaces around keyword / parameter equals Line 133:63: E251 unexpected spaces around keyword / parameter equals Line 139:80: E501 line too long (86 > 79 characters) Line 150:76: E251 unexpected spaces around keyword / parameter equals Line 150:78: E251 unexpected spaces around keyword / parameter equals Line 150:80: E501 line too long (82 > 79 characters) Line 151:76: E251 unexpected spaces around keyword / parameter equals Line 151:78: E251 unexpected spaces around keyword / parameter equals Line 151:80: E501 line too long (82 > 79 characters) Line 153:80: E501 line too long (93 > 79 characters) Line 171:76: E251 unexpected spaces around keyword / parameter equals Line 171:78: E251 unexpected spaces around keyword / parameter equals Line 171:80: E501 line too long (82 > 79 characters) Line 172:76: E251 unexpected spaces around keyword / parameter equals Line 172:78: E251 unexpected spaces around keyword / parameter equals Line 172:80: E501 line too long (82 > 79 characters) Line 173:21: E225 missing whitespace around operator Line 175:23: E225 missing whitespace around operator Line 183:80: E501 line too long (93 > 79 characters) Line 184:30: W291 trailing whitespace Line 194:80: E501 line too long (93 > 79 characters) Line 195:30: W291 trailing whitespace Line 206:80: E501 line too long (93 > 79 characters) Line 207:30: W291 trailing whitespace Line 225:76: E251 unexpected spaces around keyword / parameter equals Line 225:78: E251 unexpected spaces around keyword / parameter equals Line 225:80: E501 line too long (82 > 79 characters) Line 226:76: E251 unexpected spaces around keyword / parameter equals Line 226:78: E251 unexpected spaces around keyword / parameter equals Line 226:80: E501 line too long (82 > 79 characters) Line 227:21: E225 missing whitespace around operator Line 227:30: E225 missing whitespace around operator Line 228:39: W291 trailing whitespace Line 229:80: E251 unexpected spaces around keyword / parameter equals Line 229:80: E501 line too long (86 > 79 characters) Line 229:82: E251 unexpected spaces around keyword / parameter equals Line 230:80: E251 unexpected spaces around keyword / parameter equals Line 230:80: E501 line too long (86 > 79 characters) Line 230:82: E251 unexpected spaces around keyword / parameter equals Line 232:26: E203 whitespace before ',' Line 232:80: E501 line too long (81 > 79 characters) Line 242:80: E501 line too long (86 > 79 characters) Line 253:62: E203 whitespace before ':' Line 266:76: E251 unexpected spaces around keyword / parameter equals Line 266:78: E251 unexpected spaces around keyword / parameter equals Line 266:80: E501 line too long (82 > 79 characters) Line 267:76: E251 unexpected spaces around keyword / parameter equals Line 267:78: E251 unexpected spaces around keyword / parameter equals Line 267:80: E501 line too long (82 > 79 characters) Line 268:21: E225 missing whitespace around operator Line 268:30: E225 missing whitespace around operator Line 269:39: W291 trailing whitespace Line 270:80: E251 unexpected spaces around keyword / parameter equals Line 270:80: E501 line too long (86 > 79 characters) Line 270:82: E251 unexpected spaces around keyword / parameter equals Line 271:80: E251 unexpected spaces around keyword / parameter equals Line 271:80: E501 line too long (86 > 79 characters) Line 271:82: E251 unexpected spaces around keyword / parameter equals Line 273:26: E203 whitespace before ',' Line 273:80: E501 line too long (81 > 79 characters) Line 297:80: E501 line too long (86 > 79 characters) Line 315:80: E501 line too long (94 > 79 characters)
- In the file
src/tespy/tools/fluid_properties/helpers.py:
Line 67:80: E501 line too long (112 > 79 characters) Line 72:20: E231 missing whitespace after ',' Line 72:31: E231 missing whitespace after ','
- In the file
src/tespy/tools/fluid_properties/mixtures.py:
Line 84:1: W293 blank line contains whitespace Line 174:80: E501 line too long (81 > 79 characters) Line 230:80: E501 line too long (93 > 79 characters)
- In the file
src/tespy/tools/fluid_properties/wrappers.py:
Line 193:34: E231 missing whitespace after ',' Line 193:36: E231 missing whitespace after ',' Line 193:38: E231 missing whitespace after ',' Line 200:32: W291 trailing whitespace Line 203:17: E722 do not use bare 'except' Line 204:21: E265 block comment should start with '# ' Line 204:80: E501 line too long (86 > 79 characters) Line 209:41: E231 missing whitespace after ',' Line 209:80: E501 line too long (91 > 79 characters) Line 209:92: W291 trailing whitespace Line 211:36: W291 trailing whitespace Line 214:21: E722 do not use bare 'except' Line 215:25: E265 block comment should start with '# ' Line 215:80: E501 line too long (90 > 79 characters) Line 217:42: E231 missing whitespace after ',' Line 217:80: E501 line too long (91 > 79 characters) Line 217:92: W291 trailing whitespace Line 219:36: W291 trailing whitespace Line 222:21: E722 do not use bare 'except' Line 223:25: E265 block comment should start with '# ' Line 223:80: E501 line too long (86 > 79 characters) Line 226:51: W291 trailing whitespace Line 229:36: E231 missing whitespace after ',' Line 229:38: E231 missing whitespace after ',' Line 262:36: E231 missing whitespace after ',' Line 274:36: E231 missing whitespace after ',' Line 282:36: E231 missing whitespace after ','
- In the file
src/tespy/tools/global_vars.py:
Line 23:23: E203 whitespace before ',' Line 23:80: E501 line too long (81 > 79 characters) Line 24:80: E501 line too long (83 > 79 characters) Line 25:80: E501 line too long (83 > 79 characters) Line 26:80: E501 line too long (83 > 79 characters) Line 27:80: E501 line too long (84 > 79 characters) Line 28:28: E203 whitespace before ',' Line 28:80: E501 line too long (93 > 79 characters) Line 29:80: E501 line too long (93 > 79 characters) Line 30:80: E501 line too long (93 > 79 characters) Line 31:80: E501 line too long (94 > 79 characters) Line 32:80: E501 line too long (94 > 79 characters) Line 34:9: E265 block comment should start with '# ' Line 35:9: E265 block comment should start with '# ' Line 41:80: E501 line too long (84 > 79 characters) Line 44:9: E131 continuation line unaligned for hanging indent Line 44:9: E265 block comment should start with '# ' Line 45:9: E265 block comment should start with '# ' Line 50:24: E203 whitespace before ',' Line 51:27: E203 whitespace before ',' Line 52:27: E203 whitespace before ',' Line 53:27: E203 whitespace before ',' Line 54:28: E203 whitespace before ',' Line 56:29: E203 whitespace before ',' Line 57:30: E203 whitespace before ',' Line 58:30: E203 whitespace before ',' Line 59:31: E203 whitespace before ',' Line 60:31: E203 whitespace before ',' Line 62:9: E265 block comment should start with '# ' Line 63:9: E265 block comment should start with '# ' Line 70:80: E501 line too long (94 > 79 characters) Line 72:9: E265 block comment should start with '# ' Line 73:9: E265 block comment should start with '# ' Line 87:80: E501 line too long (94 > 79 characters) Line 88:80: E501 line too long (94 > 79 characters)
- In the file
src/tespy/tools/helpers.py:
Line 22:80: E501 line too long (80 > 79 characters) Line 113:1: E302 expected 2 blank lines, found 1 Line 119:1: E302 expected 2 blank lines, found 1
fwitte
I tried working with git-filter-repo to separate the core code from the application specific new parts to split the changes into two repositories, which was unsuccessful. There seems to be something really strange in the history of the ipudk fork, which is why I ended up cherry picking the commits and adding a commit on top of that deleting the respective files, which would not be part of the core.