Closed Nzb0731 closed 1 month ago
Hello @Nzb0731! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
tutorial/basics/rankine.py
:Line 58:1: E402 module level import not at top of file Line 59:1: E402 module level import not at top of file Line 60:1: E402 module level import not at top of file
Hi @Nzb0731,
thank you for your contribution. I'll review the PR this week and let you know, how to proceed.
Best
Francesco
Thanks for your contribution @Nzb0731, I made some smaller modifications (better spaced isobars and some isenthalpics) and added a darkmode figure as well. I will also make some minor changes to fluprodia to enable compatibility to darkmode plotting with matplotlib.
Hi @fwitte,
Thank you for approving the PR and for the modifications to make this feature better. I am also grateful for the open-source model, which has enabled me to complete my final year project.
Best wishes, Zhen Bin
General
I am a chemical engineering student working on a final year project using TESPy to study modelling of Rankine cycles.
During my studies, I generate a T-s diagram to the Rankine cycle model using the fluprodia package, as recommended in the documentation. This is useful for analysis purposes, e.g., to validate the correctness of the model. For example, if the T-s diagram does not form a closed-loop, there could be something wrong in the model.
We have also updated the documentation of Rankine cycles to reflect the changes. We thought this could be helpful to other users in the future, hence opening this PR.