search

oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermal engineering plants such as power plants, district heating systems or heat pumps.
https://tespy.readthedocs.io
MIT License
256 stars 80 forks source link

Implement a moving boundary condenser for improved part load modeling #515

Open fwitte opened 1 month ago

fwitte commented 1 month ago

Especially in heat pump or refrigeration machine applications, the condenser component may have a significant heat transfer share from the desuperheating of the working fluid. The heat transfer coefficients for desuperheating and condensation usually differ strongly, therefore using an overall kA (UA) value for the complete process to model part load may not be correct. Therefore an approach is implemented with a moving boundary, which will split the virtual area of the condenser into a desuperheating and a condensation part. The split will happen proportionally to the heat transfer of each subprocess and be validated using reference data.

pep8speaks commented 1 month ago

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 63:80: E501 line too long (98 > 79 characters) Line 65:80: E501 line too long (104 > 79 characters) Line 72:80: E501 line too long (114 > 79 characters) Line 75:80: E501 line too long (83 > 79 characters) Line 86:80: E501 line too long (98 > 79 characters) Line 152:24: E222 multiple spaces after operator Line 222:80: E501 line too long (87 > 79 characters) Line 232:25: E222 multiple spaces after operator Line 238:80: E501 line too long (81 > 79 characters) Line 239:80: E501 line too long (89 > 79 characters) Line 259:80: E501 line too long (90 > 79 characters) Line 260:80: E501 line too long (85 > 79 characters) Line 264:80: E501 line too long (84 > 79 characters) Line 265:80: E501 line too long (81 > 79 characters) Line 270:80: E501 line too long (87 > 79 characters) Line 293:80: E501 line too long (83 > 79 characters) Line 324:24: E222 multiple spaces after operator Line 366:26: E222 multiple spaces after operator Line 373:80: E501 line too long (85 > 79 characters) Line 384:80: E501 line too long (86 > 79 characters) Line 385:80: E501 line too long (81 > 79 characters) Line 389:80: E501 line too long (153 > 79 characters) Line 392:80: E501 line too long (172 > 79 characters)

Line 1:80: E501 line too long (93 > 79 characters) Line 90:1: E402 module level import not at top of file Line 102:80: E501 line too long (80 > 79 characters) Line 120:16: E225 missing whitespace around operator Line 128:80: E501 line too long (123 > 79 characters) Line 129:80: E501 line too long (107 > 79 characters)

Comment last updated at 2024-05-30 03:34:22 UTC