oemof / tespy

Thermal Engineering Systems in Python (TESPy). This package provides a powerful simulation toolkit for thermodynamic modeling of thermal engineering plants such as power plants, heat pumps or refrigeration machines.
https://tespy.readthedocs.io
MIT License
281 stars 86 forks source link

Implement a moving boundary condenser for improved part load modeling #515

Open fwitte opened 6 months ago

fwitte commented 6 months ago

Especially in heat pump or refrigeration machine applications, the condenser component may have a significant heat transfer share from the desuperheating of the working fluid. The heat transfer coefficients for desuperheating and condensation usually differ strongly, therefore using an overall kA (UA) value for the complete process to model part load may not be correct. Therefore an approach is implemented with a moving boundary, which will split the virtual area of the condenser into a desuperheating and a condensation part. The split will happen proportionally to the heat transfer of each subprocess and be validated using reference data.

pep8speaks commented 6 months ago

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 38:80: E501 line too long (83 > 79 characters) Line 52:80: E501 line too long (80 > 79 characters) Line 75:80: E501 line too long (87 > 79 characters) Line 77:80: E501 line too long (84 > 79 characters) Line 162:80: E501 line too long (92 > 79 characters) Line 214:80: E501 line too long (88 > 79 characters) Line 215:80: E501 line too long (92 > 79 characters) Line 268:24: E222 multiple spaces after operator Line 329:80: E501 line too long (92 > 79 characters) Line 330:80: E501 line too long (96 > 79 characters) Line 343:80: E501 line too long (84 > 79 characters)

Line 1:80: E501 line too long (93 > 79 characters) Line 92:1: E402 module level import not at top of file Line 103:80: E501 line too long (82 > 79 characters) Line 104:80: E501 line too long (81 > 79 characters) Line 150:80: E501 line too long (82 > 79 characters) Line 151:80: E501 line too long (81 > 79 characters) Line 160:32: W292 no newline at end of file

Comment last updated at 2024-08-06 15:26:04 UTC