oerdnj / deb.sury.org

Public bugreports for anything ppa:ondrej/*
800 stars 26 forks source link

session.gc_maxlifetime php.ini comment references php8.2-common README for at least 8.1, 8.3 #2115

Open GreenReaper opened 2 months ago

GreenReaper commented 2 months ago

Frequently asked questions

Describe the bug This is really small, but the php.ini comment update for php8.1 and php8.3 (and possibly other versions) references the php8.2 README, which is not present on the system.

When I installed php8.1-cli and php8.1-fpm, I was directed to resolve a difference in my modified php.ini including the block:

; This is disabled in the Debian packages due to the strict permissions
; on /var/lib/php. Instead, GC is performed through /etc/cron.d/php,
; which uses the session.gc_maxlifetime setting. Please, check
; /usr/share/doc/php8.2-common/README.Debian.gz for further reference.

When I try to access this file:

$ ls /usr/share/doc/php8.2-common/README.Debian.gz
ls: cannot access '/usr/share/doc/php8.2-common/README.Debian.gz': No such file or directory

To Reproduce Steps to reproduce the behaviour:

  1. Have a php8.1 or php8.3 installation (for which you have optionally modified php.ini)
  2. Upgrade to 8.1.27-4+0~20240411.60+debian12~1.gbp279e30 or 8.3.6-1+0~20240411.28+debian12~1.gbp9a7ce5 respectively.
  3. Inspect the php.ini and try to access the referenced README for more information
  4. See an error since the file is not there

Your understanding of what is happening The source file has the same version number referenced in the comment for all versions of php.ini (or at least those for 8.1/8.3).

What steps did you take to resolve issue yourself before reporting it here I inspected the README file paths, replacing 8.2 with 8.1 and 8.3, and found that the README was present and contained a section Session storage relevant to session.gc_maxlifetime. I then corrected the comment in the relevant php.ini files.

Expected behaviour I expected the PHP 8.1/8.3 php.ini comment to reference a PHP 8.1/8.3 README that was present on the system.

Distribution (please complete the following information):

Package(s) (please complete the following information):

php8.1-cli:
  Installed: 8.1.27-4+0~20240411.60+debian12~1.gbp279e30
  Candidate: 8.1.27-4+0~20240411.60+debian12~1.gbp279e30
  Version table:
 *** 8.1.27-4+0~20240411.60+debian12~1.gbp279e30 500
        500 https://packages.sury.org/php bookworm/main amd64 Packages
        100 /var/lib/dpkg/status
php8.3-cli:
  Installed: 8.3.6-1+0~20240411.28+debian12~1.gbp9a7ce5
  Candidate: 8.3.6-1+0~20240411.28+debian12~1.gbp9a7ce5
  Version table:
 *** 8.3.6-1+0~20240411.28+debian12~1.gbp9a7ce5 500
        500 https://packages.sury.org/php bookworm/main amd64 Packages
        100 /var/lib/dpkg/status
php8.1-fpm:
  Installed: 8.1.27-4+0~20240411.60+debian12~1.gbp279e30
  Candidate: 8.1.27-4+0~20240411.60+debian12~1.gbp279e30
  Version table:
 *** 8.1.27-4+0~20240411.60+debian12~1.gbp279e30 500
        500 https://packages.sury.org/php bookworm/main amd64 Packages
        100 /var/lib/dpkg/status
php8.3-fpm:
  Installed: 8.3.6-1+0~20240411.28+debian12~1.gbp9a7ce5
  Candidate: 8.3.6-1+0~20240411.28+debian12~1.gbp9a7ce5
  Version table:
 *** 8.3.6-1+0~20240411.28+debian12~1.gbp9a7ce5 500
        500 https://packages.sury.org/php bookworm/main amd64 Packages
        100 /var/lib/dpkg/status

Additional context I wised up and started using conf.d for my PHP 8.3 install and so I was not prompted to resolve a php.ini diff for it, so the error would not be visible for most users, unless they later inspected the file and tried to open the referenced README.