search

oere / progressive-learning-platform

Automatically exported from code.google.com/p/progressive-learning-platform
GNU General Public License v3.0
0 stars 0 forks source link

Excessive carriage returns in .asm file #198

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The nightly build of PLPToolStatic appears to be inserting excessive CRs (0x0D) 
in the .asm file. This causes issues when trying to view the source files with 
PLPTool 3.3 or 4.0-dev or a 3rd party text viewer/editor. The build appears to 
ignore extra CRs when displaying the file so it appears normally in the GUI.

PLPTool version: 4.0-release-120211 (nightly)
Java version: JRE7 1.7.0_02 (64-bit)

Original issue reported on code.google.com by gaals...@gmail.com on 11 Feb 2012 at 9:13

GoogleCodeExporter commented 8 years ago

Original comment by david.jakob.fritz on 11 Feb 2012 at 4:40

GoogleCodeExporter commented 8 years ago 
I can't seem to reproduce this. Can you attach a PLP file produced by the 
nightly with excessive CR characters?

Original comment by wheerdam@gmail.com on 11 Feb 2012 at 9:56

GoogleCodeExporter commented 8 years ago 
Ok this is a terrible bug. May have to rewrite the syntax highlighter.

Original comment by wheerdam@gmail.com on 11 Feb 2012 at 10:33

GoogleCodeExporter commented 8 years ago 
Looks like the culprit is the setEditorText(String) method in 
plptool/gui/frames/Develop.java. Instead of messing with the document object 
for the editor, I just used setText 
(http://code.google.com/p/progressive-learning-platform/source/detail?r=8e53d595
3620dd2410e867181d10a0c108618b06)

I think the editor and syntax is highlighting is due for upgrades.

Original comment by wheerdam@gmail.com on 12 Feb 2012 at 2:57

GoogleCodeExporter commented 8 years ago 
Tried last night's nightly build, the editor correctly showed the excessive 
carriage returns and I was able to remove them and continue using the program 
normally. I am not able to reproduce this issue at this time.

Original comment by gaals...@gmail.com on 12 Feb 2012 at 8:39

GoogleCodeExporter commented 8 years ago

Original comment by wheerdam@gmail.com on 13 Feb 2012 at 4:45