search

oers / reversatile

Reversatile: Reversi for Android
GNU General Public License v3.0
19 stars 6 forks source link

Make board fill whole screen width #67

Closed Insti closed 5 years ago

Insti commented 5 years ago

I think it is better that the board fill as much of the screen as possible and the addtional status text shrinks to fit the remaining space. This PR make sure the board does this.

Screenshots are from the head of the develop branch which already includes some changes to the status area text.

Before:

Screenshot_20190707-211253

After:

Screenshot_1563392686

oers commented 5 years ago

Have you tried this with several screen sizes? My latest problem was, that the status view is still too large on some devices and the possibilities of automatic sizes for fonts etc did not work very well for me.

Insti commented 5 years ago

I've tested on a few different device screen sizes using the emulator. I have another PR on the way that fixes the status view.

Can you tell me which sizes cause problems?

oers commented 5 years ago

Mostly screens that were very wide. But when I look at your screen shot it looks like one of the devices that made trouble.

Insti commented 5 years ago

If anyone has a square screen that's probably going to be a problem.