search

oers / reversatile

Reversatile: Reversi for Android
GNU General Public License v3.0
19 stars 6 forks source link

Refactor BoardView: Colors & Disc drawing. #75

Closed Insti closed 5 years ago

Insti commented 5 years ago

This PR does 2 main things.

  1. Extracts the color member variables to their own class and standardizes the use of colors to always use these resource-based color values.

  2. Extracts a drawDiscs method from the giant onDraw method. Simplifying (hopefully) the disc drawing logic and removing several unnecessary class variables.

It should not change the appearance of the rendered board/animations at all.

oers commented 5 years ago

thank you, looks cleaner :)