search

oesmith / puffing-billy

A rewriting web proxy for testing interactions between your browser and external sites. Works with ruby + rspec.
MIT License
660 stars 168 forks source link

Fix Selenium::WebDriver::Firefox deprecation warning #229

Closed pjmelling closed 5 years ago

pjmelling commented 6 years ago

Passing a :profile option directly to ::Capybara::Selenium::Driver.new is deprecated. A custom Firefox profile should be assigned to a Selenium::WebDriver::Firefox::Options instance with #profile=. This options instance is then passed to ::Capybara::Selenium::Driver.new.

See the comment on #profile= here: https://github.com/SeleniumHQ/selenium/blob/2300e36377b8609938c94f1211aff117e2a483a6/rb/lib/selenium/webdriver/firefox/options.rb#L109

pjmelling commented 6 years ago

Looks like the CI build for this is failing like it is for https://github.com/oesmith/puffing-billy/pull/228. It doesn't look like it's related to this PR's changes.

ronwsmith commented 6 years ago

Thanks for the contribution @pjmelling ! Can you include the warning message and confirm it goes away with this change? I don't think the test suite covers all drivers appropriately so I wanted to double-check.

ronwsmith commented 6 years ago

FYI, looks like this is also addressed in https://github.com/oesmith/puffing-billy/pull/234

ronwsmith commented 6 years ago

@pjmelling Any update on this PR?

ronwsmith commented 5 years ago

Stale PR, closing. Feel free to reopen and continue with review feedback.