search

oesmith / puffing-billy

A rewriting web proxy for testing interactions between your browser and external sites. Works with ruby + rspec.
MIT License
656 stars 170 forks source link

Update eventmachine gem from 1.0.4 to 1.2 #251

Closed mwjeffcott closed 5 years ago

mwjeffcott commented 6 years ago

As I mentioned in #217, 1.0.x versions of eventmachine mean that Puffing Billy cannot be used when dealing with resources over HTTP/2, but I see that the version of eventmachine was set back again in #212 due to compatibility issues with watir. I want to use the latest version of Puffing Billy in order to get access to some of the new features, so I'm going to try bumping eventmachine again.

All of the unit tests passed for me, once I made the small change here in test_server.rb. This looks similar to the issue I described in #217 where localhost won't work, but 127.0.0.1 will.

mrageh commented 5 years ago

Will this get merged into puffing_billy soon?

ronwsmith commented 5 years ago

Released in 1.1.3 @mwjeffcott / @mrageh

mwjeffcott commented 5 years ago

@ronwsmith Thanks a lot, appreciate the merge and the update!