search

oesmith / puffing-billy

A rewriting web proxy for testing interactions between your browser and external sites. Works with ruby + rspec.
MIT License
656 stars 170 forks source link

Add driver registration for apparition driver #258

Closed twalpole closed 5 years ago

twalpole commented 5 years ago

This PR adds a default registration for the Apparition (Chrome via CDP) driver - https://github.com/twalpole/apparition

ronwsmith commented 5 years ago

@twalpole thanks for the contribution! Mind removing travis support for ruby 2.0.0-2.2.0 since they aren't supported by apparition, and then adding ruby 2.5.0?

twalpole commented 5 years ago

@ronwsmith Done

thbar commented 5 years ago

@twalpole I wonder if it's worth adding the fix you provided here https://github.com/twalpole/apparition/issues/2#issuecomment-458807373 to this PR?

twalpole commented 5 years ago

@thbar - I don't think the default position should be to ignore certs - It would be better for a user to get their certs worked out somehow (I haven't actually gone through what it would take with apparition for that yet) than to disable proxy cert checking.

thbar commented 5 years ago

@twalpole ok so then I suggest it would be good to add a note to the puffing billy readme nearby a section introducing the driver, because this is going to catch people off-guard quite a bit (= all https calls are not proxied, and this will cause problems in some cases, especially if dealing with VCR & payments gateways).

(I can prepare a PR for that little note if the maintainers agree!)

ronwsmith commented 5 years ago

Released as 2.0.0