oesmith / puffing-billy

A rewriting web proxy for testing interactions between your browser and external sites. Works with ruby + rspec.

MIT License

656 stars 170 forks source link

Add Selenium headless driver #272

Closed xtrasimplicity closed 4 years ago

xtrasimplicity commented 5 years ago

Background

The selenium_billy driver doesn't appear to support headless mode, and also (though unrelated) throws a Selenium [DEPRECATION] :profile is deprecated. Use Selenium::WebDriver::Firefox::Options#profile= instead. warning.

Summary

I've simply refactored the selenium_billy driver so that we're no longer using the deprecated method of setting a profile, and then added a selenium_headless_billy driver with headless support.

xtrasimplicity commented 5 years ago

Note: The CI failures aren't to do with my code -- looks like there's an issue with dependencies in the CI environment itself.

ronwsmith commented 4 years ago

@xtrasimplicity Thanks for the contribution! If you have a chance to try addressing the CI issue, please feel free, so I'll try to tackle in a few weeks.

xtrasimplicity commented 4 years ago

Thanks, @ronwsmith. I'll take a look and will submit a new PR for the CI issue.

xtrasimplicity commented 4 years ago

Scratch that, someone else has come up with a CI fix as part of another PR: https://github.com/oesmith/puffing-billy/pull/273 :)

xtrasimplicity commented 4 years ago

Hi @ronwsmith, any updates on this and #273? Thanks!

ronwsmith commented 4 years ago

@xtrasimplicity I'm back! Thanks for your contribution and patience.

ronwsmith commented 4 years ago

Released in v2.2.0