search

oesmith / puffing-billy

A rewriting web proxy for testing interactions between your browser and external sites. Works with ruby + rspec.
MIT License
654 stars 170 forks source link

Include lib/tasks/billy.rake #320

Closed Aesthetikx closed 2 years ago

Aesthetikx commented 2 years ago

I think this file loads lib/tasks/billy.rake, however this commit changed away from using git ls-files and no longer includes lib/tasks/billy.rake, which is raising an error on CI after upgrading to 3x. Not sure if that was intentional or not.

Best, John

ronwsmith commented 2 years ago

Thanks @Aesthetikx !

@AlfonsoUceda can you take a look and see if we should revert that gemspec change?

AlfonsoUceda commented 2 years ago

Hey @Aesthetikx @ronwsmith sorry for that problem. What I would do instead is add that file to the gemspec.

ronwsmith commented 2 years ago

@AlfonsoUceda mind putting up a PR for that? I'll release as 3.0.2

AlfonsoUceda commented 2 years ago

Yep, will do tomorrow

Aesthetikx commented 2 years ago

Thanks y'all, and no worries! Could have probably done it myself but it has been a while since I have worked with actual gems. Thanks for the hard work.

ronwsmith commented 2 years ago

@Aesthetikx please update to 3.0.2 and report back if that resolved your CI issues.

Aesthetikx commented 2 years ago

@ronwsmith All green! :green_apple: :green_book: :green_circle: :green_heart: