Closed wynksaiddestroy closed 4 months ago
Thanks for the contribution! I don't think the failures are related but can you take a look and see if you can resolve them?
Thanks for the contribution! I don't think the failures are related but can you take a look and see if you can resolve them?
I'm not quite sure how to address this issue properly. It seems that calling
will somehow cause the browser to actually visit https://example.com(:443). Thus trying to find the stub will fail. See d831973 for a provisional fix.
@wynksaiddestroy I'm good with that fix, thanks! Looks like there are problems running on Ruby head though now.
Can you take a look (or remove head)?
@wynksaiddestroy I'm good with that fix, thanks! Looks like there are problems running on Ruby head though now.
Can you take a look (or remove head)?
It's because em-socksify
doesn't have base64 as an (explicit) dependency yet. I already created a PR. See igrigorik/em-socksify#25
I propose we'll wait a few days an see whether the PR gets merged soon.
Looks like the other PR was merged but CI here is still failing. Please let me know when I should try again.
Looks like the other PR was merged but CI here is still failing. Please let me know when I should try again.
There's no new version released yet. I just asked the author, if he plans to do it.
@ronwsmith A new version of em-socksify just got released. Could you please try again?
Huzzah, thanks for the contribution!
As #342 seems to got stuck. Here's a new attempt: