search

oesmith / ralio

A usable command-line client for Rally
https://github.com/oesmith/ralio
30 stars 21 forks source link

NO plain password into .raliorc #20

Closed tinogomes closed 11 years ago

oesmith commented 11 years ago

Base64 doesn't really add any significant value here, does it? You'd be just as well off using ROT13...

This should NOT be merged. Investigate using the operating system keychain instead. node-keychain might be a good start.

igorescobar commented 11 years ago

@oesmith I agree. But, about the keychain, We should find a way to store password on a cross platform fashion and it shouldn't be easy.

tinogomes commented 11 years ago

@igorescobar I don't think retro-compatibility is not necessary for this case, cause the idea is to "secure" the password, but do your better!

@oesmith, like @igorescobar, I agree on all aspects. This pull request is only to obfuscate the password, and I think is better than plain text.

I saw the TODO List and think to use some key store solution instead of .raliorc. I found keytool, an cross platform solution, but it will gerenate a Java dependecy, and I think that is bad idea.